Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): implement remove-unsafe-symlinks flag for cachi2 #2145

Conversation

ben-alkov
Copy link
Member

@ben-alkov ben-alkov commented Jan 20, 2025

What/why:

implement parsing remove-unsafe-symlinks flag, which toggles removing all symlinks which point to location(s) outside of any cloned repository (default False)

How:

  • parse flag remove-unsafe-symlinks from "remote-source" section of 'container.yaml'

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Python type annotations added to new code
  • JSON/YAML configuration changes are updated in the relevant schema
  • Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates
  • New feature can be disabled from a configuration file

@ben-alkov ben-alkov requested a review from MartinBasti January 20, 2025 17:54
@ben-alkov ben-alkov force-pushed the feat-cachi2-remove-unsafe-symlinks-flag branch from df536e9 to a12efcd Compare January 21, 2025 23:13
What/why:

implement parsing `remove-unsafe-symlinks` flag, which toggles
removing all symlinks which point to location(s) outside of any cloned
repository (default `False`)

How:

 - parse flag `remove-unsafe-symlinks` from "remote-source" section of   'container.yaml'

Signed-off-by: Ben Alkov <ben.alkov@redhat.com>
@ben-alkov ben-alkov force-pushed the feat-cachi2-remove-unsafe-symlinks-flag branch from a12efcd to 7db0ca8 Compare January 21, 2025 23:26
@ben-alkov ben-alkov merged commit d766c1a into containerbuildsystem:feature_cachi2 Jan 22, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants