Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for tarerofs for TurboOCI #272

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

salvete2022
Copy link

What this PR does / why we need it:

Add a very basic support for EROFS local OCI convertion for TurboOCI.

The corresponding overlaybd PR:
containerd/overlaybd#320

The corresponding erofs-utils for test can be found at:
git clone https://gitee.com/anolis/erofs-utils.git -b overlaybd-dev

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Let's add an item `defaultFsType` to `/etc/overlaybd-snapshotter/config.json`,
For example:
{
	...
	"defaultFsType": "erofs"
}

Signed-off-by: Hongzhen Luo <hongzhen.lhz@linux.alibaba.com>
@yuchen0cc yuchen0cc added the ok-to-test Pull request is ok to run ci test label Mar 27, 2024
Copy link
Member

@liulanzheng liulanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is a very basic support for EROFS local OCI convertion.

Unlike EXT4, EROFS doesn't need a `--import` and `export` pair to
generate modified tar headers first since erofs-utils just needs to
parse tar streams once.

Even for parallel convertion, erofs-utils will use EROFS layer blobs
directly.

Also, EROFS doesn't have an explicit `--mkfs` step since `mkfs.erofs`
can handle layer imports directly.

Signed-off-by: Hongzhen Luo <hongzhen.lhz@linux.alibaba.com>
@liulanzheng liulanzheng merged commit ba8e12d into containerd:main Mar 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Pull request is ok to run ci test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants