Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the metrics exporter #282

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix the metrics exporter #282

merged 1 commit into from
Nov 3, 2023

Conversation

Coldwings
Copy link
Contributor

@Coldwings Coldwings commented Nov 3, 2023

What this PR does / why we need it:

Fix metrics collecting and prometheus exporter service. Uses metrics.h in photon library. Make metrics_fs.h collect query latency, throughput, query per second, accumulated read bytes as metrics. Add license header for those files that used in metrics.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Coldwings <coldwings@me.com>
Copy link
Member

@liulanzheng liulanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liulanzheng liulanzheng merged commit bacb344 into containerd:main Nov 3, 2023
2 checks passed
liulanzheng added a commit to liulanzheng/overlaybd that referenced this pull request Nov 7, 2023
fix the metrics exporter

Signed-off-by: Lanzheng Liu <lanzheng.liulz@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants