Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch erofs endpoint to use https #341

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

estebanreyl
Copy link
Member

@estebanreyl estebanreyl commented Aug 5, 2024

What this PR does / why we need it:
This PR is a tiny change to move the erofs dependency from using the git protocol to https. The main reasoning behind it is to better support builds behind firewalls which have become more and more strict in recent times as security pushes happen. We have encountered such issues where firewalls restrict ports other than 443 and 80 for security but using the git protocol uses 9418.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Esteban Rey <esrey@microsoft.com>
@BigVan
Copy link
Member

BigVan commented Aug 6, 2024

Thanks

@BigVan BigVan merged commit 3952d6a into containerd:main Aug 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants