Fixes #1096: read log output by chunks if a line is too long #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking into this. The code looks good. Could you please add a release note? See newsfragments/README.txt for instructions and other files in that directory for inspiration. |
|
Also, please run |
|
Thanks for reviewing. Here is my attempt to resolve the issues you mentioned. |
|
I updated PR by running |
Fixes containers#1096. Modified-by: Povilas Kanapickas <povilas@radix.lt> Signed-off-by: Yusuke Matsubara <whym@whym.org>
|
Fixed pylint error as well. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to solve the freeze issue described in #1096.
The approach taken here is the more conservative, but less simple version I mentioned in the issue.