-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable secret types #50
base: master
Are you sure you want to change the base?
feat: enable secret types #50
Conversation
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
========================================
+ Coverage 59.3% 59.6% +0.4%
========================================
Files 8 8
Lines 368 371 +3
========================================
+ Hits 218 221 +3
Misses 119 119
Partials 31 31
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there,
Thanks a lot for the PR, I think this feature make sense. I've left a few comments requesting clarification.
c61923a
to
64a7cfc
Compare
Hi there 👋 and thanks a lot for the contribution, seems interesting! Wondering: should we do some value validation? It seems the list of valid values is pretty small: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/auth/secrets.md#secret-api-resource ? Or can there be more values to this? |
The original code assume that all synced secrets would be
Opaque
.This change allows the user to add the correct key to the
SyncedSecret
to set theSecretType