Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable secret types #50

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dwa012-zmi
Copy link

@dwa012-zmi dwa012-zmi commented Oct 23, 2020

The original code assume that all synced secrets would be Opaque.
This change allows the user to add the correct key to the SyncedSecret to set the SecretType

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #50 into master will increase coverage by 0.4%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #50     +/-   ##
========================================
+ Coverage    59.3%   59.6%   +0.4%     
========================================
  Files           8       8             
  Lines         368     371      +3     
========================================
+ Hits          218     221      +3     
  Misses        119     119             
  Partials       31      31             
Impacted Files Coverage Δ
pkg/k8ssecret/secret.go 80.7% <100.0%> (+0.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 720c4b1...64a7cfc. Read the comment docs.

Copy link
Contributor

@argvk argvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there,

Thanks a lot for the PR, I think this feature make sense. I've left a few comments requesting clarification.

api/v1/syncedsecret_types.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@dwa012-zmi dwa012-zmi force-pushed the feat/add-custom-secret-type branch from c61923a to 64a7cfc Compare October 28, 2020 13:53
@yannh
Copy link
Collaborator

yannh commented Oct 28, 2020

Hi there 👋 and thanks a lot for the contribution, seems interesting! Wondering: should we do some value validation? It seems the list of valid values is pretty small: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/auth/secrets.md#secret-api-resource ? Or can there be more values to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants