ConfigHandler: make updateIdeSettings work

ConfigHandler.updateIdeSettings() was largely ineffective because the
ideSettingsPromise was stored in the ProfileLoader object, so updating
to a new ideSettingsPromise resulted in the config being reloaded
with the old settings. Fix this by passing the ideSettingsPromise as
a parameter to IProfileLoader.doLoadConfig().

core/config/ConfigHandler.ts

@@ -51,7 +51,6 @@ export class ConfigHandler {
     // Set local profile as default
     const localProfileLoader = new LocalProfileLoader(
       ide,
-      ideSettingsPromise,
       controlPlaneClient,
       writeLog,
     );
@@ -111,7 +110,6 @@ export class ConfigHandler {
             workspace.name,
             this.controlPlaneClient,
             this.ide,
-            this.ideSettingsPromise,
             this.writeLog,
             this.reloadConfig.bind(this),
           );
@@ -214,7 +212,7 @@ export class ConfigHandler {
     // TODO: this isn't right, there are two different senses in which you want to "reload"
 
     const { config, errors, configLoadInterrupted } =
-      await this.currentProfile.reloadConfig();
+      await this.currentProfile.reloadConfig(this.ideSettingsPromise);
 
     if (config) {
       this.inactiveProfiles.forEach((profile) => profile.clearConfig());
@@ -226,6 +224,7 @@ export class ConfigHandler {
 
   getSerializedConfig(): Promise<BrowserSerializedContinueConfig> {
     return this.currentProfile.getSerializedConfig(
+      this.ideSettingsPromise,
       this.additionalContextProviders,
     );
   }
@@ -235,7 +234,7 @@ export class ConfigHandler {
   }
 
   async loadConfig(): Promise<ContinueConfig> {
-    return this.currentProfile.loadConfig(this.additionalContextProviders);
+    return this.currentProfile.loadConfig(this.ideSettingsPromise, this.additionalContextProviders);
   }
 
   async llmFromTitle(title?: string): Promise<ILLM> {

core/config/ProfileLifecycleManager.ts

@@ -2,6 +2,7 @@ import {
   BrowserSerializedContinueConfig,
   ContinueConfig,
   IContextProvider,
+  IdeSettings,
 } from "../index.js";
 
 import { ConfigResult, finalToBrowserConfig } from "./load.js";
@@ -41,15 +42,16 @@ export class ProfileLifecycleManager {
   }
 
   // Clear saved config and reload
-  async reloadConfig(): Promise<ConfigResult<ContinueConfig>> {
+  async reloadConfig(ideSettingsPromise: Promise<IdeSettings>): Promise<ConfigResult<ContinueConfig>> {
     this.savedConfig = undefined;
     this.savedBrowserConfig = undefined;
     this.pendingConfigPromise = undefined;
 
-    return this.profileLoader.doLoadConfig();
+    return this.profileLoader.doLoadConfig(ideSettingsPromise);
   }
 
   async loadConfig(
+    ideSettingsPromise: Promise<IdeSettings>,
     additionalContextProviders: IContextProvider[],
   ): Promise<ContinueConfig> {
     // If we already have a config, return it
@@ -62,7 +64,7 @@ export class ProfileLifecycleManager {
     // Set pending config promise
     this.pendingConfigPromise = new Promise(async (resolve, reject) => {
       const { config: newConfig, errors } =
-        await this.profileLoader.doLoadConfig();
+        await this.profileLoader.doLoadConfig(ideSettingsPromise);
 
       if (newConfig) {
         // Add registered context providers
@@ -86,10 +88,11 @@ export class ProfileLifecycleManager {
   }
 
   async getSerializedConfig(
+    ideSettingsPromise: Promise<IdeSettings>,
     additionalContextProviders: IContextProvider[],
   ): Promise<BrowserSerializedContinueConfig> {
     if (!this.savedBrowserConfig) {
-      const continueConfig = await this.loadConfig(additionalContextProviders);
+      const continueConfig = await this.loadConfig(ideSettingsPromise, additionalContextProviders);
       this.savedBrowserConfig = finalToBrowserConfig(continueConfig);
     }
     return this.savedBrowserConfig;

core/config/profile/ControlPlaneProfileLoader.ts

@@ -25,7 +25,6 @@ export default class ControlPlaneProfileLoader implements IProfileLoader {
     private workspaceTitle: string,
     private readonly controlPlaneClient: ControlPlaneClient,
     private readonly ide: IDE,
-    private ideSettingsPromise: Promise<IdeSettings>,
     private writeLog: (message: string) => Promise<void>,
     private readonly onReload: () => void,
   ) {
@@ -39,7 +38,7 @@ export default class ControlPlaneProfileLoader implements IProfileLoader {
     }, ControlPlaneProfileLoader.RELOAD_INTERVAL);
   }
 
-  async doLoadConfig(): Promise<ConfigResult<ContinueConfig>> {
+  async doLoadConfig(ideSettingsPromise: Promise<IdeSettings>): Promise<ConfigResult<ContinueConfig>> {
     const settings =
       this.workspaceSettings ??
       ((await this.controlPlaneClient.getSettingsForWorkspace(
@@ -49,7 +48,7 @@ export default class ControlPlaneProfileLoader implements IProfileLoader {
 
     const results = await doLoadConfig(
       this.ide,
-      this.ideSettingsPromise,
+      ideSettingsPromise,
       this.controlPlaneClient,
       this.writeLog,
       serializedConfig,

core/config/profile/IProfileLoader.ts

@@ -1,12 +1,15 @@
 // ProfileHandlers manage the loading of a config, allowing us to abstract over different ways of getting to a ContinueConfig
 
-import { ContinueConfig } from "../../index.js";
+import {
+  ContinueConfig,
+  IdeSettings,
+} from "../../index.js";
 import { ConfigResult } from "../load.js";
 
 // After we have the ContinueConfig, the ConfigHandler takes care of everything else (loading models, lifecycle, etc.)
 export interface IProfileLoader {
   profileTitle: string;
   profileId: string;
-  doLoadConfig(): Promise<ConfigResult<ContinueConfig>>;
+  doLoadConfig(ideSettingsPromise: Promise<IdeSettings>): Promise<ConfigResult<ContinueConfig>>;
   setIsActive(isActive: boolean): void;
 }

core/config/profile/LocalProfileLoader.ts

@@ -12,15 +12,14 @@ export default class LocalProfileLoader implements IProfileLoader {
 
   constructor(
     private ide: IDE,
-    private ideSettingsPromise: Promise<IdeSettings>,
     private controlPlaneClient: ControlPlaneClient,
     private writeLog: (message: string) => Promise<void>,
   ) {}
 
-  async doLoadConfig(): Promise<ConfigResult<ContinueConfig>> {
+  async doLoadConfig(ideSettingsPromise: Promise<IdeSettings>): Promise<ConfigResult<ContinueConfig>> {
     return doLoadConfig(
       this.ide,
-      this.ideSettingsPromise,
+      ideSettingsPromise,
       this.controlPlaneClient,
       this.writeLog,
       undefined,