Merge pull request #2882 from continuedev/nate/tests

save to cache immediately so as not to fail tests
continuedev · Nov 12, 2024 · d2fa937 · d2fa937
2 parents d69f4d9 + f4159d2
commit d2fa937
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 30 deletions.
diff --git a/core/autocomplete/CompletionProvider.ts b/core/autocomplete/CompletionProvider.ts
@@ -261,13 +261,10 @@ export class CompletionProvider {
 
       //////////
 
-      // Do some stuff later so as not to block return. Latency matters
-      const completionToCache = outcome.completion;
-      setTimeout(async () => {
-        if (!outcome.cacheHit) {
-          (await this.autocompleteCache).put(outcome.prefix, completionToCache);
-        }
-      }, 100);
+      // Save to cache
+      if (!outcome.cacheHit) {
+        (await this.autocompleteCache).put(outcome.prefix, outcome.completion);
+      }
 
       // When using the JetBrains extension, Mark as displayed
       const ideType = (await this.ide.getIdeInfo()).ideType;

diff --git a/core/autocomplete/filtering/test/filter.test.ts b/core/autocomplete/filtering/test/filter.test.ts
@@ -14,7 +14,7 @@ const filterTestCases = (tests: AutocompleteFileringTestInput[]) => {
   return tests;
 };
 
-describe("llms/Mock", () => {
+describe("Autocomplete filtering tests", () => {
   beforeAll(async () => {
     tearDownTestDir();
     setUpTestDir();
@@ -24,27 +24,25 @@ describe("llms/Mock", () => {
     tearDownTestDir();
   });
 
-  describe("Autocomplete Filtering Tests", () => {
-    beforeEach(async () => {
-      await new Promise((resolve) => setTimeout(resolve, 50));
-    });
-
-    describe("Should return unmodified LLM output", () => {
-      it.each(filterTestCases(TEST_CASES_WITHOUT_DIFF))(
-        "$description",
-        async (testCase) => {
-          await testAutocompleteFiltering(testCase);
-        },
-      );
-    });
-
-    describe("Should return modified LLM output", () => {
-      it.each(filterTestCases(TEST_CASES_WITH_DIFF))(
-        "$description",
-        async (testCase) => {
-          await testAutocompleteFiltering(testCase);
-        },
-      );
-    });
+  beforeEach(async () => {
+    await new Promise((resolve) => setTimeout(resolve, 50));
+  });
+
+  describe("Should return unmodified LLM output", () => {
+    it.each(filterTestCases(TEST_CASES_WITHOUT_DIFF))(
+      "$description",
+      async (testCase) => {
+        await testAutocompleteFiltering(testCase);
+      },
+    );
+  });
+
+  describe("Should return modified LLM output", () => {
+    it.each(filterTestCases(TEST_CASES_WITH_DIFF))(
+      "$description",
+      async (testCase) => {
+        await testAutocompleteFiltering(testCase);
+      },
+    );
   });
 });