Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TrackingBundle] fix template notation for tracking #664

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

dpfaffenbauer
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no

LiipTheme introduced a Bug here, so we decided to change the notation, since the colon notation is not supported in Symfony 4 anymore as well.

liip/LiipThemeBundle#194

@dpfaffenbauer dpfaffenbauer requested a review from solverat October 5, 2018 21:48
@dpfaffenbauer dpfaffenbauer added this to the 2.0.0-RC.1 milestone Oct 5, 2018
@dpfaffenbauer dpfaffenbauer self-assigned this Oct 5, 2018
@dpfaffenbauer dpfaffenbauer merged commit 2772092 into master Oct 5, 2018
@dpfaffenbauer dpfaffenbauer deleted the tracking-templates branch October 5, 2018 21:48
@anyt
Copy link

anyt commented Jan 18, 2019

Hi @dpfaffenbauer ,
I have no complaints about bugfix, but here you say

the colon notation is not supported in Symfony 4 anymore as well.

Could you confirm it with some link to the code or documentation? Can not found it by myself.

@dpfaffenbauer
Copy link
Member Author

Guess I am mistaken here. Seems it is still supported, they deprecated only the colon notation for controllers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants