Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embarrassing SupportedGameVersion crash #164

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

pawnishoovy
Copy link
Contributor

shuffles some code around so a missing SupportedGameVersion correctly warns the player (and lets him ignore it) instead of throwing a meaningless error message and crashing out.

@pawnishoovy pawnishoovy added the bug Something isn't working label Dec 7, 2024
@pawnishoovy pawnishoovy requested a review from Causeless December 7, 2024 03:29
@pawnishoovy pawnishoovy self-assigned this Dec 7, 2024
Copy link
Contributor

@Causeless Causeless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@Causeless Causeless added this pull request to the merge queue Dec 7, 2024
Merged via the queue into development with commit bea2868 Dec 7, 2024
4 checks passed
@Causeless Causeless deleted the supported-version-crash branch December 7, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants