Ft/backend #150
Ft/backend #150
Conversation
| @@ -0,0 +1 @@ | |||
| sharedash | |||
There was a problem hiding this comment.
this file should be in the .gitignore
| @@ -0,0 +1,29 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
This migration file shouldn't be committed
| @@ -0,0 +1,23 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # Generated by Django 1.10.3 on 2017-03-29 17:30 | |||
There was a problem hiding this comment.
Same as above, this migration file shouldn't be committed
| @@ -0,0 +1,56 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # Generated by Django 1.10.3 on 2017-03-29 17:30 | |||
There was a problem hiding this comment.
Please remove this migration file as well
| @@ -1,8 +1,8 @@ | |||
| DATABASES = { | |||
There was a problem hiding this comment.
Local setting should be in the .gitignore
| @@ -408,8 +406,10 @@ export default Ember.Component.extend({ | |||
| picking: false, | |||
|
|
|||
| init() { | |||
|
|
|||
| debugger; | |||
There was a problem hiding this comment.
Please remove the stray debugger statement
| //this.sendAction('refreshWall'); | ||
| debugger; |
There was a problem hiding this comment.
Please remove the stray debugger statement
| @@ -8,6 +8,10 @@ | |||
|
|
|||
| class Dashboard(Model): | |||
|
|
|||
| id = CharField( | |||
There was a problem hiding this comment.
As discussed earlier, please move the dashboard and widget models into the api app
| class Widget(Model): | ||
|
|
||
| title = CharField( |
There was a problem hiding this comment.
Is title the same as chartType?
| @@ -3,8 +3,8 @@ import JSONAPIAdapter from 'ember-data/adapters/json-api'; | |||
| import config from '../config/environment'; | |||
|
|
|||
| export default JSONAPIAdapter.extend({ | |||
|
|
|||
| host: config.APP.GRANTS_BACKEND, | |||
| host: 'http://localhost:8000', | |||
There was a problem hiding this comment.
Instead of defining the host in each adapter, you can define it once in the application adapter and extend it here and in the dashboard adapter
|
Please bring this PR up to date with master |
|
Done reviewing @birdbrained! ☀️ |
|
Continued in #154 |
No description provided.