Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v0.47.4 #423

Closed
wants to merge 2 commits into from
Closed

feat: v0.47.4 #423

wants to merge 2 commits into from

Conversation

kimurayu45z
Copy link

  • cosmos-sdk v0.47.4
  • ibc-go v7.2.0
  • wasmd v0.41.0
  • using buf.build/community/neoeinstein-prost:v0.2.3 for latest buf toolchains
  • using buf.build/community/neoeinstein-tonic:v0.3.0 for latest buf toolchains

@kimurayu45z
Copy link
Author

seems to have git submodule checkout problems... the contents are not updated...

@kimurayu45z
Copy link
Author

fn update_submodules() {
    info!("Updating cosmos/cosmos-sdk submodule...");
    run_git(["submodule", "update", "--init"]);
    run_git(["-C", COSMOS_SDK_DIR, "fetch"]);
    run_git(["-C", COSMOS_SDK_DIR, "reset", "--hard", COSMOS_SDK_REV]);

    info!("Updating cosmos/ibc-go submodule...");
    run_git(["submodule", "update", "--init"]);
    run_git(["-C", IBC_DIR, "fetch"]);
    run_git(["-C", IBC_DIR, "reset", "--hard", IBC_REV]);

    info!("Updating wasmd submodule...");
    run_git(["submodule", "update", "--init"]);
    run_git(["-C", WASMD_DIR, "fetch"]);
    run_git(["-C", WASMD_DIR, "reset", "--hard", WASMD_REV]);
}

checking out revision via this function seems not working.

@tony-iqlusion
Copy link
Member

@kimurayu45z can you try rebasing? I've made a lot of upstream changes to the proto generation

I'd like to hold off on trying to do this update for the upcoming release since we'd also need to bump Tendermint/CometBFT versions to v0.37.

But if you can get it working we can get it into the next release after that.

@tony-iqlusion
Copy link
Member

Closing in favor of #459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants