fix(x/auth/tx): avoid panic from newWrapperFromDecodedTx

when AuthInfo.Fee is optional in decodedTx

CHANGELOG.md

@@ -51,6 +51,7 @@ Every module contains its own CHANGELOG.md. Please refer to the module you are i
 ### Bug Fixes
 
 * (query) [23002](https://github.com/cosmos/cosmos-sdk/pull/23002) Fix collection filtered pagination.
+* (x/auth/tx) [#23170](https://github.com/cosmos/cosmos-sdk/pull/23170) Avoid panic from newWrapperFromDecodedTx when AuthInfo.Fee is optional in decodedTx.
 
 ### API Breaking Changes
 

x/auth/tx/gogotx.go

@@ -31,6 +31,9 @@ import (
 func newWrapperFromDecodedTx(
 	addrCodec address.Codec, cdc codec.BinaryCodec, decodedTx *decode.DecodedTx,
 ) (*gogoTxWrapper, error) {
+	if decodedTx.Tx.AuthInfo.Fee == nil {
+		return nil, fmt.Errorf("missing fee")
+	}
 	var (
 		fees = sdk.Coins{} // decodedTx.Tx.AuthInfo.Fee.Amount might be nil
 		err  error

x/auth/tx/gogotx_test.go

@@ -0,0 +1,26 @@
+package tx
+
+import (
+	"testing"
+
+	v1beta1 "cosmossdk.io/api/cosmos/tx/v1beta1"
+	"cosmossdk.io/x/tx/decode"
+	"github.com/cosmos/cosmos-sdk/codec"
+	addresscodec "github.com/cosmos/cosmos-sdk/codec/address"
+	codectestutil "github.com/cosmos/cosmos-sdk/codec/testutil"
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	"github.com/stretchr/testify/require"
+)
+
+func TestNewWrapperFromDecodedTx(t *testing.T) {
+	addrCodec := addresscodec.NewBech32Codec(sdk.GetConfig().GetBech32AccountAddrPrefix())
+	codecOpt := codectestutil.CodecOptions{}
+	interfaceRegistry := codecOpt.NewInterfaceRegistry()
+	cdc := codec.NewProtoCodec(interfaceRegistry)
+	_, err := newWrapperFromDecodedTx(addrCodec, cdc, &decode.DecodedTx{
+		Tx: &v1beta1.Tx{
+			AuthInfo: &v1beta1.AuthInfo{},
+		},
+	})
+	require.NotNil(t, err)
+}