chore: remove appmanager poc #22422

tac0turtle · 2024-11-04T19:32:45Z

Description

this pr moves the stateful part of stf to consensus & removes the runtime identity

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

coderabbitai · 2024-11-04T19:33:06Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

server/v2/cometbft/abci.go

+			return nil, true, err
+		}
+
+		res, err = c.stf.Query(ctx, queryState, c.cfg.AppTomlConfig.QueryGasLimit, protoRequest)


server/v2/cometbft/abci.go

+		if err != nil {
+			return nil, true, err
+		}
+		res, err = c.stf.Query(ctx, state, c.cfg.AppTomlConfig.QueryGasLimit, protoRequest)


julienrbrt · 2024-11-18T12:29:46Z

runtime/v2/builder.go

@@ -112,14 +112,7 @@ func (a *AppBuilder[T]) Build(opts ...AppBuilderOption[T]) (*App[T], error) {
 	}
 	a.app.stf = stf

-	a.app.AppManager = appmanager.New[T](
-		appmanager.Config{


We should remove that from runtime v2 config then and from the the appconfig

julienrbrt · 2024-11-18T12:30:36Z

server/v2/appmanager/appmanager.go

would that genesis manager stay in appmanager go.mod? I thought the idea of removing appmanager was to kill that extra go.mod as well 🤔

julienrbrt · 2024-11-18T12:32:24Z

runtime/v2/app.go

@@ -88,6 +88,11 @@ func (a *App[T]) QueryHandlers() map[string]appmodulev2.Handler {
 	return a.queryHandlers
 }

+// StateTransitionFunction returns the state transition function.
+func (a *App[T]) StateTransitionFunction() *stf.STF[T] {


i don't think we should return the concrete type here

tac0turtle · 2024-11-27T10:37:27Z

clsoing as we dont have the capacity to complete and retest

tac0turtle added 3 commits October 31, 2024 13:25

remove runtime identity

dbebb9e

work on removing appmanage

7f919b5

more testing

69b3a6b

github-actions bot added C:server/v2 Issues related to server/v2 C:server/v2 stf C:server/v2 appmanager C:server/v2 cometbft C:server/v2 api labels Nov 4, 2024

further resolving

e05c4a7

github-advanced-security bot found potential problems Nov 4, 2024

View reviewed changes

Merge branch 'main' into marko/appmanager_removal

fb7c432

tac0turtle force-pushed the marko/appmanager_removal branch from 494fdee to fb7c432 Compare November 11, 2024 11:07

tac0turtle and others added 4 commits November 11, 2024 12:10

fix some errors

f799f0b

Merge branch 'main' into marko/appmanager_removal

22b99f5

cleanup

8e12f1b

building

e2d604f

tac0turtle force-pushed the marko/appmanager_removal branch from 44d62aa to e2d604f Compare November 12, 2024 13:35

julienrbrt reviewed Nov 18, 2024

View reviewed changes

tac0turtle closed this Nov 27, 2024

julienrbrt deleted the marko/appmanager_removal branch November 27, 2024 11:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove appmanager poc #22422

chore: remove appmanager poc #22422

tac0turtle commented Nov 4, 2024

coderabbitai bot commented Nov 4, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

julienrbrt Nov 18, 2024

julienrbrt Nov 18, 2024

julienrbrt Nov 18, 2024

tac0turtle commented Nov 27, 2024

chore: remove appmanager poc #22422

chore: remove appmanager poc #22422

Conversation

tac0turtle commented Nov 4, 2024

Description

Author Checklist

Reviewers Checklist

coderabbitai bot commented Nov 4, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

julienrbrt Nov 18, 2024

Choose a reason for hiding this comment

julienrbrt Nov 18, 2024

Choose a reason for hiding this comment

julienrbrt Nov 18, 2024

Choose a reason for hiding this comment

tac0turtle commented Nov 27, 2024