fix(systemtests): wait longer to detect double sign #23286
Conversation
📝 WalkthroughWalkthroughThe pull request modifies the Changes
Sequence DiagramsequenceDiagram
participant Test as Fraud Test
participant SUT as System Under Test
loop Block Processing Check (100 times)
Test->>SUT: AwaitNextBlock()
Test-->>Test: Wait 6 seconds
end
Possibly related PRs
Suggested labels
Suggested reviewers
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/systemtests/fraud_test.go (1)
47-48: Consider making the timeout configurableThe hardcoded values for iterations and delay could be made configurable to allow easier tuning without code changes.
Consider this approach:
+const ( + // DefaultDoubleSignDetectionMaxAttempts is the default number of attempts to detect double signing + DefaultDoubleSignDetectionMaxAttempts = 100 + // DefaultDoubleSignDetectionDelay is the default delay between attempts in seconds + DefaultDoubleSignDetectionDelay = 6 +) func TestValidatorDoubleSign(t *testing.T) { // ... existing code ... - for i := 0; i < 100; i++ { - systest.Sut.AwaitNextBlock(t, 6*time.Second) + maxAttempts := systest.GetIntConfig("DOUBLE_SIGN_DETECTION_MAX_ATTEMPTS", DefaultDoubleSignDetectionMaxAttempts) + delaySeconds := systest.GetIntConfig("DOUBLE_SIGN_DETECTION_DELAY", DefaultDoubleSignDetectionDelay) + for i := 0; i < maxAttempts; i++ { + systest.Sut.AwaitNextBlock(t, time.Duration(delaySeconds)*time.Second)This would allow adjusting the values through environment variables while maintaining sensible defaults.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/systemtests/fraud_test.go(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
tests/systemtests/fraud_test.go (3)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"
Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
⏰ Context from checks skipped due to timeout of 90000ms (12)
- GitHub Check: tests (03)
- GitHub Check: tests (02)
- GitHub Check: tests (01)
- GitHub Check: tests (00)
- GitHub Check: test-simapp-v2
- GitHub Check: test-system-v2
- GitHub Check: test-integration
- GitHub Check: build (arm64)
- GitHub Check: Analyze
- GitHub Check: build (amd64)
- GitHub Check: golangci-lint
- GitHub Check: Summary
🔇 Additional comments (2)
tests/systemtests/fraud_test.go (2)
10-10: LGTM: Import addition is correctThe
timeimport is properly placed and necessary for the new timeout functionality.
47-48: Verify the timeout valuesThe increased iteration count (100) and delay (6s) significantly extend the maximum wait time to 10 minutes. While this aligns with the PR objective to wait longer for double sign detection, please verify if these specific values were chosen based on empirical evidence.
Could you share the reasoning behind choosing 6 seconds specifically? Were there test runs that showed this was the optimal delay?
julienrbrt
added
the
backport/v0.52.x
for more info, https://github.com/cosmos/cosmos-sdk/actions/runs/12701390978/job/35405814980?pr=23285
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit