chore: use cosmossdk.io/core/codec instead of github.com/cosmos/cosmos-sdk/codec in store.go and keeper.go #23294
Conversation
…github.com/cosmos/cosmos-sdk/codec in store.go and keeper.go
tiendn
requested review from
alpe,
lucaslopezf,
a team and
julienrbrt
as code owners
📝 WalkthroughWalkthroughThis pull request involves updating the codec import path in two different files from the Cosmos SDK's traditional codec import to a new import path under the Cosmossdk.io namespace. The changes are specifically in the governance ( Changes
Possibly related PRs
Suggested reviewers
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
x/gov/migrations/v5/store.go (1)
Line range hint
55-55: Fix typo in comment.There's a typo in the comment: "consisitution" should be "constitution".
- // Set the default consisitution if it is not set + // Set the default constitution if it is not set🧰 Tools
🪛 golangci-lint (1.62.2)
9-9: File is not
gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order(gci)
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
x/gov/migrations/v5/store.go(1 hunks)x/nft/keeper/keeper.go(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- x/nft/keeper/keeper.go
🧰 Additional context used
📓 Path-based instructions (1)
x/gov/migrations/v5/store.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (2)
x/gov/migrations/v5/store.go (2)
Line range hint
24-24: LGTM! Codec interface usage is correct.The function correctly uses the codec.BinaryCodec interface from the new import path without requiring any implementation changes.
🧰 Tools
🪛 golangci-lint (1.62.2)
9-9: File is not
gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order(gci)
10-10: LGTM! Verify consistency across the codebase.The import path change aligns with the PR objectives. Let's verify that this change is consistent across other files using the codec package.
✅ Verification successful
Import change is correct and follows the established pattern
The change to
cosmossdk.io/core/codecaligns with:
- The project's use of stable
cosmossdk.io/core v1.0.0- The consistent pattern seen in other migrated files
- The broader migration to the
cosmossdk.ionamespace🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any remaining old codec imports that might need updating # and verify the consistency of the new import path usage echo "Checking for old codec imports..." rg --type go "github.com/cosmos/cosmos-sdk/codec" echo "Verifying new codec import usage..." rg --type go "cosmossdk.io/core/codec"Length of output: 61172
Script:
#!/bin/bash # Check migration files and their codec imports echo "Checking migration files codec imports..." rg --type go --glob "*/migrations/**/store.go" "^import.*codec" echo -e "\nChecking for documentation about codec import changes..." rg --type go --type md "cosmossdk.io/core/codec" -B 2 -A 2Length of output: 2167
Script:
#!/bin/bash # Find migration files and check their imports echo "Finding migration files..." fd -t f store.go migrations/ echo -e "\nChecking migration files content..." fd -t f store.go migrations/ -x cat {} echo -e "\nChecking go.mod for codec dependencies..." grep -A 5 "cosmossdk.io/core" go.modLength of output: 755
Description
Partially addresses: #23253
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
The modifications represent a technical migration of codec package imports, maintaining the existing behavior of the system while updating to a newer dependency source.