chore: finish prep beta.2 #23411
chore: finish prep beta.2 #23411
Conversation
📝 WalkthroughWalkthroughThis pull request introduces structured changelog management across multiple modules in the Cosmos SDK repository. The changes primarily focus on updating changelog files for Changes
Possibly related PRs
Suggested Labels
Suggested Reviewers
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
C:server/v2
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
server/v2/appmanager/CHANGELOG.md (1)
27-27: Fix typo in changelog entryThere's a typo in the changelog message: "generated" should be "generating".
-* [#23013](https://github.com/cosmos/cosmos-sdk/pull/23013) Introduce `TransactionFuzzer`, an interface for processing and generated state transitions. +* [#23013](https://github.com/cosmos/cosmos-sdk/pull/23013) Introduce `TransactionFuzzer`, an interface for processing and generating state transitions.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
runtime/v2/go.sumis excluded by!**/*.sumserver/v2/go.sumis excluded by!**/*.sum
📒 Files selected for processing (10)
runtime/v2/CHANGELOG.md(1 hunks)runtime/v2/go.mod(1 hunks)server/v2/CHANGELOG.md(1 hunks)server/v2/appmanager/CHANGELOG.md(1 hunks)server/v2/cometbft/go.mod(1 hunks)server/v2/commands.go(1 hunks)server/v2/go.mod(1 hunks)server/v2/stf/CHANGELOG.md(1 hunks)simapp/v2/go.mod(3 hunks)tests/go.mod(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- runtime/v2/CHANGELOG.md
🧰 Additional context used
📓 Path-based instructions (5)
server/v2/CHANGELOG.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
server/v2/appmanager/CHANGELOG.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
tests/go.mod (1)
Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"
server/v2/commands.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
server/v2/stf/CHANGELOG.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: test-system-v2
- GitHub Check: Summary
- GitHub Check: Summary
- GitHub Check: Analyze
🔇 Additional comments (10)
server/v2/commands.go (1)
208-208: Improvement in command name retrieval logicThe change from
cmd.Usetocmd.Name()is a good improvement as it provides a more precise way to get the command name without any additional usage information or formatting that might be present in theUsefield.server/v2/stf/CHANGELOG.md (1)
25-28: LGTM! Changelog entry follows guidelinesThe changelog entry is well-formatted with:
- Proper version linking
- Clear reference to the GitHub issue
- Concise description of the new feature
server/v2/CHANGELOG.md (1)
25-28: LGTM! Well-structured changelog entriesThe changelog entries are properly formatted with:
- Clear version linking
- GitHub issue references
- Concise descriptions of changes
runtime/v2/go.mod (2)
18-19: Version updates look consistent.The updates to
appmanagerandstfdependencies align with changes in other modules, maintaining version consistency across the codebase.Also applies to: 21-21
21-21: Notable upgrade: tx module reaches stable version.The
cosmossdk.io/x/txdependency has been upgraded fromv1.0.0-alpha.3tov1.0.0, marking a significant milestone as it moves from alpha to a stable release.Let's verify the compatibility of this major version change:
✅ Verification successful
Verified: The tx module upgrade to v1.0.0 is safe to proceed.
The upgrade from v1.0.0-alpha.3 to v1.0.0 marks the stabilization of the tx module's API. The module is extensively used across core components for transaction handling, signing, and verification. The graduation from alpha to stable release indicates API maturity and stability, making this a safe upgrade.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any breaking changes in tx module usage # Search for any imports or usage of the tx module that might be affected rg -l "cosmossdk.io/x/tx"Length of output: 4455
Script:
#!/bin/bash # Search for actual imports and usage of tx module in non-test files # Exclude go.mod, go.sum, and test files rg "cosmossdk.io/x/tx" \ --type go \ --glob '!*_test.go' \ -B 2 -A 2 \ --no-ignoreLength of output: 12795
server/v2/go.mod (1)
16-16: Version update is consistent.The update of
appmanagerdependency tov1.0.0-beta.2maintains consistency with other modules.server/v2/cometbft/go.mod (1)
25-26: Version updates are consistent.The updates to both
appmanagerandstfdependencies tov1.0.0-beta.2maintain consistency with other modules.tests/go.mod (1)
29-29: Version updates are consistent.The updates to both
appmanagerandstfdependencies tov1.0.0-beta.2maintain consistency with other modules.Also applies to: 74-74
simapp/v2/go.mod (2)
15-15: Version updates are consistent.The updates to both
appmanagerandstfdependencies tov1.0.0-beta.2maintain consistency with other modules.Also applies to: 68-68
19-19: New dependencies added.The following new dependencies have been added:
cosmossdk.io/tools/confixcosmossdk.io/x/accounts/defaults/lockupPlease ensure these new dependencies are necessary and their pseudo-versions (0.0.0-00010101000000-000000000000) are replaced with proper versions in the replace directives.
Let's verify the usage of these new dependencies:
Also applies to: 22-22
✅ Verification successful
Dependencies are properly managed and necessary
Both new dependencies are internal modules with proper replace directives:
cosmossdk.io/tools/confix=>../../tools/confixcosmossdk.io/x/accounts/defaults/lockup=>../../x/accounts/defaults/lockupThe pseudo-versions are correctly handled by local replace directives, and both modules show legitimate usage in the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for actual usage of the new dependencies # Search for imports of the new modules rg -l "cosmossdk.io/tools/confix" rg -l "cosmossdk.io/x/accounts/defaults/lockup"Length of output: 1622
Script:
#!/bin/bash # Check replace directives in go.mod cat simapp/v2/go.mod | grep -A 1 "replace"Length of output: 670
Script:
#!/bin/bash # View complete go.mod file cat simapp/v2/go.modLength of output: 15041
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
server/v2/appmanager/CHANGELOG.md (1)
27-27: Enhance the changelog entry description.While the entry follows the correct format, it could be more descriptive about the purpose and impact of introducing the
TransactionFuzzerinterface. Consider adding details about:
- Why this interface was introduced
- What problems it solves
- How it benefits users or developers
-* [#23013](https://github.com/cosmos/cosmos-sdk/pull/23013) Introduce `TransactionFuzzer`, an interface for processing and generated state transitions. +* [#23013](https://github.com/cosmos/cosmos-sdk/pull/23013) Introduce `TransactionFuzzer`, an interface for processing and generating state transitions. This interface enhances testing capabilities by allowing systematic exploration of state transitions and transaction validation scenarios.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
runtime/v2/go.sumis excluded by!**/*.sumserver/v2/go.sumis excluded by!**/*.sum
📒 Files selected for processing (10)
runtime/v2/CHANGELOG.md(1 hunks)runtime/v2/go.mod(1 hunks)server/v2/CHANGELOG.md(1 hunks)server/v2/appmanager/CHANGELOG.md(1 hunks)server/v2/cometbft/go.mod(1 hunks)server/v2/commands.go(1 hunks)server/v2/go.mod(1 hunks)server/v2/stf/CHANGELOG.md(1 hunks)simapp/v2/go.mod(3 hunks)tests/go.mod(2 hunks)
✅ Files skipped from review due to trivial changes (2)
- tests/go.mod
- runtime/v2/CHANGELOG.md
🧰 Additional context used
📓 Path-based instructions (4)
server/v2/commands.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
server/v2/stf/CHANGELOG.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
server/v2/appmanager/CHANGELOG.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
server/v2/CHANGELOG.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Summary
- GitHub Check: Summary
- GitHub Check: Analyze
🔇 Additional comments (8)
server/v2/commands.go (1)
208-208: LGTM! Using cmd.Name() improves command path matching precision.The change from
cmd.Usetocmd.Name()ensures more accurate command path matching by using only the command name without usage information.Let's verify that all command paths are correctly matched with this change:
✅ Verification successful
Verified: cmd.Name() is the correct choice for command path matching
The change is verified to be correct as the
IsAppRequiredfunction compares against pre-defined command paths that contain only command names. Usingcmd.Name()instead ofcmd.Useensures exact matching without interference from usage information.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Find all cobra command definitions and their usage patterns rg -U "cobra\.Command\s*=\s*&cobra\.Command\s*{[^}]*Use:\s*\"([^\"]+)\"" -g "*.go"Length of output: 265
Script:
#!/bin/bash # Find cobra command definitions with their Use and Name fields ast-grep --pattern 'cobra.Command{ $$$ Use: $_, $$$ }' # Find command path related code rg -A 3 "cmdPath.*append" -g "*.go"Length of output: 296
Script:
#!/bin/bash # Get more context around the command path usage rg -B 10 -A 10 "cmdPath.*append" server/v2/commands.go # Find command name definitions ast-grep --pattern 'cobra.Command{ $$$ Name: $_, $$$ }'Length of output: 676
server/v2/stf/CHANGELOG.md (1)
25-28: LGTM! Well-formatted changelog entry.The changelog entry follows the guidelines, properly references PR #23013, and clearly describes the introduction of the DeliverSims interface.
server/v2/CHANGELOG.md (1)
25-28: LGTM! Comprehensive changelog entries for beta.2.The changelog entries are well-structured, properly reference PRs, and clearly describe the changes made in this release.
runtime/v2/go.mod (1)
18-21: Verify compatibility with the stable x/tx v1.0.0 release.The dependency updates align with the beta.2 release. However, the significant version jump for
cosmossdk.io/x/txfromv1.0.0-alpha.3tov1.0.0warrants verification of compatibility.Let's check for any breaking changes in x/tx v1.0.0:
✅ Verification successful
The update to x/tx v1.0.0 is compatible with the codebase
The version upgrade from v1.0.0-alpha.3 to v1.0.0 represents a stabilization release with no breaking changes. Recent alpha releases focused on bug fixes and improvements, maintaining backward compatibility.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Find all imports and usages of x/tx package rg -l "cosmossdk.io/x/tx" --type go # Find all method calls from x/tx package ast-grep --pattern 'tx.$_($_)'Length of output: 2976
Script:
#!/bin/bash # Check for changelog fd CHANGELOG.md cat x/tx/CHANGELOG.md || true # Look for recent release commits git log --oneline --grep="x/tx" -n 10Length of output: 10141
server/v2/go.mod (1)
16-16: LGTM: Version update aligns with beta.2 preparation.The update of
cosmossdk.io/server/v2/appmanagertov1.0.0-beta.2is consistent with the PR objectives.server/v2/cometbft/go.mod (1)
25-26: LGTM: Consistent version updates for beta.2.Both dependency updates to
v1.0.0-beta.2are consistent:
cosmossdk.io/server/v2/appmanagercosmossdk.io/server/v2/stfsimapp/v2/go.mod (2)
15-15: LGTM: Version updates consistent with beta.2 preparation.The updates to
v1.0.0-beta.2for bothappmanagerandstfpackages align with the PR objectives and are consistent with other module updates.Also applies to: 68-68
19-23: Verify local module replacements.The placeholder versions (0.0.0-00010101000000-000000000000) for local modules are correctly managed through replace directives at the bottom of the file.
✅ Verification successful
All placeholder versions are properly managed through replace directives
All modules using the placeholder version (0.0.0-00010101000000-000000000000) have corresponding replace directives pointing to local paths, which is the correct setup for local development.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that all placeholder versions have corresponding replace directives echo "Checking for placeholder versions and their replace directives..." rg "v0\.0\.0-00010101000000-000000000000" | while read -r line; do module=$(echo "$line" | awk '{print $1}') echo "Checking replace directive for $module" rg "replace.*$module.*=>" doneLength of output: 504
Script:
#!/bin/bash # Display the content of simapp/v2/go.mod echo "Content of simapp/v2/go.mod:" cat simapp/v2/go.modLength of output: 15108
| @@ -22,6 +22,10 @@ Each entry must include the Github issue reference in the following format: | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ## [v1.0.0-beta.2](https://github.com/cosmos/cosmos-sdk/releases/tag/server/v2/stf%2Fv1.0.0-beta.2) | |||
There was a problem hiding this comment.
Fix incorrect release tag URL.
The release tag URL points to server/v2/stf instead of server/v2/appmanager. This appears to be a copy-paste error.
-## [v1.0.0-beta.2](https://github.com/cosmos/cosmos-sdk/releases/tag/server/v2/stf%2Fv1.0.0-beta.2)
+## [v1.0.0-beta.2](https://github.com/cosmos/cosmos-sdk/releases/tag/server/v2/appmanager%2Fv1.0.0-beta.2)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## [v1.0.0-beta.2](https://github.com/cosmos/cosmos-sdk/releases/tag/server/v2/stf%2Fv1.0.0-beta.2) | |
| ## [v1.0.0-beta.2](https://github.com/cosmos/cosmos-sdk/releases/tag/server/v2/appmanager%2Fv1.0.0-beta.2) |
Description
I have just tagged now that sims are integrated:
This adds the changelog and bumps it in the relevant packages.
Noticed we haven't had a changelog in runtime/v2 so adding one.
A nice follow-up would be to tag core/testing/v0.0.2 once #23355 is merged.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
TransactionFuzzerinterface for processing and generating state transitionsDeliverSimsinterface for handling state transitions by simulationsDependency Updates
cosmossdk.io/x/txto stable versionv1.0.0Changelog Improvements
v2.0.0-beta.2andv1.0.0-beta.2Bug Fixes
IsAppRequired()function