Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use runtime env in ibc 08-wasm client module #7766

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

damiannolan
Copy link
Contributor

Description

This PR is work-in-progress and should not be merged until completed.

The usage of sdk.Context should try to be removed completely.
The 08-wasm module is still relying on sdk.Context in the keeper for gas consumption.
This can be refactored out and replaced by k.GasService.

The usage of the legacy baseapp GRPCQueryRouter for the 08-wasm Querier should also try to be replaced by adding the new query router to the runtime environment using runtime.EnvWithQueryRouterService(app.GRPCQueryRouter()).

Main tasks left to complete:

  • Migrate the GasRegister to use GasService in favour of sdk.Context.
  • Refactor the Querier to use the runtime query router.

ref: #7712


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant