Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump openzeppelin to 5.2.0 and remove our own impls #209

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

gjermundgaraba
Copy link
Contributor

Description

New version of open zeppelin! Finally we can get rid of our own parsers and slicers 🙌

closes: #14


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Wrote unit and integration tests.
  • Added relevant natspec and godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@gjermundgaraba gjermundgaraba marked this pull request as ready for review January 10, 2025 00:47
@gjermundgaraba gjermundgaraba changed the title deps: bump openzeppeling to 5.2.0 and remove our own impls deps: bump openzeppelin to 5.2.0 and remove our own impls Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (f639c91) to head (68850ec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   96.97%   98.66%   +1.69%     
==========================================
  Files          11       11              
  Lines         562      526      -36     
==========================================
- Hits          545      519      -26     
+ Misses         17        7      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. The way we take benchmark has changed due to the proxy contracts. So I don't believe these new numbers are correct. I will fix these and then merge.

@srdtrk srdtrk merged commit f8ed823 into main Jan 10, 2025
60 checks passed
@srdtrk srdtrk deleted the gjermund/openzeppelin-5.2.0 branch January 10, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find an audited and tested hex string to address function
2 participants