CBG-4015 Refresh _sync:seq when releasing sequences in nextSequenceGreaterThan #6937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eaterThan Accounts for expected jumps in sequence values under variable allocator throughput before triggering “greater than” handling.
gregns1
requested changes
Jul 8, 2024
db/sequence_allocator.go
Outdated
| var numReleasedBatch uint64 | ||
| numReleasedBatch, err = s._releaseCurrentBatch(ctx) | ||
| if err != nil { | ||
| base.WarnfCtx(ctx, "Error returned when releasing sequence range [%d-%d] for existing batch. Will be handled by skipped sequence handling. Error:%v", err) |
There was a problem hiding this comment.
Suggested change
| base.WarnfCtx(ctx, "Error returned when releasing sequence range [%d-%d] for existing batch. Will be handled by skipped sequence handling. Error:%v", err) | |
| base.WarnfCtx(ctx, "Error returned when releasing sequence range [%d-%d] for existing batch. Will be handled by skipped sequence handling. Error:%v", s.last+1, s.max, err) | |
There was a problem hiding this comment.
Good catch, and this highlighted a case where we should be returning error instead of just logging. Will fix both.
gregns1
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4015
Accounts for expected jumps in sequence values under variable allocator throughput before triggering “greater than” handling.
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2547/