CBG-4370 create a cancel context inside BlipSyncContext #7201
+226
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cancel context allows a forceable closure of the underlying blip connection. In the case there is a continuous pull replication and there is an error on the changes feed, the only way to stop the pull replication is to shut down the connection. CBL clients do not listen to unsolicited error messages.
adamcfraser
requested changes
Nov 20, 2024
| @@ -34,7 +34,10 @@ const ( | |||
|
|
|||
| var ErrClosedBLIPSender = errors.New("use of closed BLIP sender") | |||
|
|
|||
| func NewBlipSyncContext(ctx context.Context, bc *blip.Context, db *Database, contextID string, replicationStats *BlipSyncStats) *BlipSyncContext { | |||
| func NewBlipSyncContext(ctx context.Context, bc *blip.Context, db *Database, contextID string, replicationStats *BlipSyncStats, ctxCancelFunc context.CancelFunc) (*BlipSyncContext, error) { | |||
| if ctxCancelFunc == nil { | |||
There was a problem hiding this comment.
Is this required for cases where the BlipSyncContext is for an active peer (ISGR)? Closing the connection in that case feels like a different problem than the passive peer case.
rest/blip_api_crud_test.go
Outdated
|
|
||
| base.SetUpTestLogging(t, base.LevelInfo, base.KeyHTTP, base.KeySync, base.KeySyncMsg, base.KeyChanges, base.KeyCache) | ||
| btcRunner := NewBlipTesterClientRunner(t) | ||
| var shouldChanenlQueryError atomic.Bool |
There was a problem hiding this comment.
Suggested change
| var shouldChanenlQueryError atomic.Bool | |
| var shouldChannelQueryError atomic.Bool |
This was referenced Nov 25, 2024
adamcfraser
approved these changes
Jan 17, 2025
torcolvin
added a commit
that referenced
this pull request
Jan 21, 2025
* CBG-4370 create a cancel context inside BlipSyncContext This cancel context allows a forceable closure of the underlying blip connection. In the case there is a continuous pull replication and there is an error on the changes feed, the only way to stop the pull replication is to shut down the connection. CBL clients do not listen to unsolicited error messages. * Avoid refactoring with the change * pass lint * test active replicator reconnection * test fixup * lint correctly * PR comments * Acquire read lock to present data race * switch query to use all docs index
torcolvin
added a commit
that referenced
this pull request
Jan 21, 2025
* CBG-4370 create a cancel context inside BlipSyncContext This cancel context allows a forceable closure of the underlying blip connection. In the case there is a continuous pull replication and there is an error on the changes feed, the only way to stop the pull replication is to shut down the connection. CBL clients do not listen to unsolicited error messages. * Avoid refactoring with the change * pass lint * test active replicator reconnection * test fixup * lint correctly * PR comments * Acquire read lock to present data race * switch query to use all docs index
bbrks
pushed a commit
that referenced
this pull request
Jan 22, 2025
…ext (#7314) * CBG-4370 preqreq deduplicate active replicator pull changes (#7211) * CBG-4370 create a cancel context inside BlipSyncContext (#7201) * CBG-4370 create a cancel context inside BlipSyncContext This cancel context allows a forceable closure of the underlying blip connection. In the case there is a continuous pull replication and there is an error on the changes feed, the only way to stop the pull replication is to shut down the connection. CBL clients do not listen to unsolicited error messages. * Avoid refactoring with the change * pass lint * test active replicator reconnection * test fixup * lint correctly * PR comments * Acquire read lock to present data race * switch query to use all docs index * fix lint issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4370 create a cancel context inside BlipSyncContext
This cancel context allows a forceable closure of the underlying blip connection.
In the case there is a continuous pull replication and there is an error on the changes feed, the only way to stop the pull replication is to shut down the connection. CBL clients do not listen to unsolicited error messages.
This leverages 6317f19
I added some leaky bucket code to be able to trigger the error.
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2826/