CBG-4203 pass RevSeqNo for on demand imports #7273
Open
+192
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamcfraser
requested changes
Jan 9, 2025
| @@ -48,6 +48,20 @@ func realDocID(docid string) string { | |||
| return docid | |||
| } | |||
|
|
|||
| // getRevSeqNo fetches the revSeqNo for a document, using the virtual xattr if available, otherwise the document body. Returns the cas from this fetch | |||
There was a problem hiding this comment.
The 'otherwise the document body' part of the comment doesn't look like it's still valid?
| return 0, 0, err | ||
| } | ||
| // CBG-4233: revSeqNo not implemented yet in rosmar | ||
| if c.dbCtx.BucketSpec.IsWalrusBucket() { |
There was a problem hiding this comment.
Should this check happen prior to line 53?
| doc, importErr = c.OnDemandImportForGet(ctx, docid, rawBucketDoc.Body, rawBucketDoc.Xattrs, rawBucketDoc.Cas) | ||
| if importErr != nil { | ||
| return nil, nil, importErr | ||
| // reload to get revseqno |
There was a problem hiding this comment.
Suggested change
| // reload to get revseqno | |
| // reload to get revseqno for on-demand import |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
RevSeqNofor on demand imports, write and get.Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2889/