feat: C++/JS proxy arrays #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the proxy types for dom::Function, dom::Object, and dom::Array. This means all js::Value and dom::Value objects can be converted back and forth.
The only current limitation is duktape does not support iterating Proxy object keys with the "ownKeys" callback, which limits virtualized objects. In practice, this means more complex JS scripts might not work well with proxy objects that originally came from C++ dom::Value. Although this is fortunately not a problem we currently have, I already reached out to find a solution to this problem.
The next step is to adapt the logic for handlebars helpers to be able to return non-primitive types.