Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDUtils class to manage ID generation and validation #473

Closed
wants to merge 13 commits into from

Conversation

Chris0296
Copy link
Contributor

@Chris0296 Chris0296 commented Oct 10, 2023

Description

By default, HAPI uses numeric IDs internally and alpha-numeric IDs for users. However, the CQF Tooling allows IDs to be numeric, which results in resources that are not compatible with the default deploy of HAPI.

This PR modifies the CQF Tooling to enforce that IDs of resources that are generated or verified by its operations are alpha-numeric, i.e. default HAPI compatible.

  • Github Issue: Ensure alpha-numeric IDs #354
  • I've read the contribution guidelines
  • Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

@Chris0296 Chris0296 changed the base branch from master to operation-overhaul October 10, 2023 22:17
Copy link
Contributor

@c-schuler c-schuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I don't see anything that ensures the IDs aren't numeric, which is what the issue details. Also please add some tests to verify behavior

This param allows us to determine if we want to allow numeric ids
overriding default HAPI behaviour
Base automatically changed from operation-overhaul to master November 28, 2023 16:27
@JPercival JPercival closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants