-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IDUtils class to manage ID generation and validation #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or other operations
…p menu for operations, and int/bool type mapping for operations
…ated dependencies
-Move ID generation methods here -Validate IDs are alphanumeric
c-schuler
requested changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I don't see anything that ensures the IDs aren't numeric, which is what the issue details. Also please add some tests to verify behavior
This param allows us to determine if we want to allow numeric ids overriding default HAPI behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default, HAPI uses numeric IDs internally and alpha-numeric IDs for users. However, the CQF Tooling allows IDs to be numeric, which results in resources that are not compatible with the default deploy of HAPI.
This PR modifies the CQF Tooling to enforce that IDs of resources that are generated or verified by its operations are alpha-numeric, i.e. default HAPI compatible.
By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0