whoopes, abort before the query is made

cranleighschool · Oct 14, 2024 · a5d65b9 · a5d65b9
1 parent 913beb2
commit a5d65b9
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/app/Domains/SelfReflection/Http/LookupController.php b/app/Domains/SelfReflection/Http/LookupController.php
@@ -9,11 +9,12 @@ class LookupController
 {
     public function __invoke(int $reportCycle): RedirectResponse
     {
-        $pupilData = new PupilData();
         if (auth()->user()->isStaff()) {
             abort(403, 'This page is intended for pupils and parents only. Staff should use the self-reflection page withing their Teaching Set in the pastoral module.');
         }
 
+        $pupilData = new PupilData();
+
 
         return redirect()->route('selfreflection.showget', ['reportCycle' => $reportCycle, 'pupilId' => $pupilData->pupil_id]);