Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: Adding pycairo #17

Merged
merged 1 commit into from
May 27, 2024
Merged

requirements: Adding pycairo #17

merged 1 commit into from
May 27, 2024

Conversation

ErwanAliasr1
Copy link
Collaborator

The default rendering engine in hwgraph is cairo, so let's ensure the dependency is explicit to avoid any issue at rendering time.

The default rendering engine in hwgraph is cairo, so let's ensure the
dependency is explicit to avoid any issue at rendering time.

Signed-off-by: Erwan Velu <e.velu@criteo.com>
Copy link
Collaborator

@beorn- beorn- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ErwanAliasr1 ErwanAliasr1 requested review from anisse and Arno500 May 27, 2024 13:39
Copy link
Contributor

@anisse anisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In the future, I'd like to split the dependencies of hwbench and hwgraph to make it clear which tool needs what.

@anisse anisse merged commit 5a1cd3e into main May 27, 2024
4 checks passed
@anisse
Copy link
Contributor

anisse commented May 28, 2024

I just realized we forgot to update the genarated requirements file (make regen_hashes)

@ErwanAliasr1 ErwanAliasr1 deleted the issue16 branch June 5, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants