Improve Bmc metrics collection #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 938cbde was adding 'packaging' dependency that wasn't added in the requirements. This commit is also regenerating hashes done with "make regen_hashes". Signed-off-by: Erwan Velu <e.velu@criteo.com>
With the current code, the mocked BMC was returning a new data structure
at each read_<component>() call.
Let's detail with the CPU temperature.
At each read_thermal() call, the thermals looks like the following :
{'CPU': {'CPU1': Temperature(name='CPU1', unit='Celsius', values=[40], mean=[], min=[], max=[], stdev=[], samples=[])}}
As per the monitoring logic, each call to read_thermal() must add a new metric in "values".
After a monitoring sampling period, mean/min/max/stdev are computed.
As values remained a single value list, the mean/min/max/stdev were
never computed leading to empty lists.
This commit is ensuring the mocked BMC is using the same logic as real
drivers so the accumulation works.
Signed-off-by: Erwan Velu <e.velu@criteo.com>
anisse
reviewed
Jun 5, 2024
The current code was a great set of code that got copy/paste over various functions and vendors. This generated lots of hard to read code which is error-prone. This commit is merging all the metric addition logic in BMC.add_monitoring_value() so it can be used across all vendors including the mocked one. Signed-off-by: Erwan Velu <e.velu@criteo.com>
This job is very useful to make a quick test on a host. It can be used to validate a fresh install or even during development phases. Signed-off-by: Erwan Velu <e.velu@criteo.com>
anisse
reviewed
Jun 5, 2024
anisse
reviewed
Jun 5, 2024
anisse
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about
fixing the broken logic in the mocked BMC that generated incorrect data structures
simplify the addition of a new metric logic to get common code across various BMC drivers
The PR was made with two commits to get a history of what was wrong in the mocked BMC driver and then the cleanup with a helper.
This PR also fixes the missing packaging python deps and adds a very simple job used during the development of this PR.