Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Create python-check.yml for github actions #3

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

beorn-
Copy link
Collaborator

@beorn- beorn- commented May 15, 2024

Let's run most of the Makefile targets to make sure everything is ok before merging

@beorn- beorn- added the enhancement New feature or request label May 15, 2024
@beorn- beorn- force-pushed the ci_configuration branch 2 times, most recently from 734677a to c905a0d Compare May 15, 2024 14:30
# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python

name: Python package
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't build any package, can you rename it and the filename too ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true. fixed.

@beorn- beorn- force-pushed the ci_configuration branch from c905a0d to 4326efb Compare May 15, 2024 14:46
@beorn- beorn- changed the title CI: Create python-package.yml for github actions CI: Create python-check.yml for github actions May 15, 2024
Enforce a few best-practices
@beorn- beorn- force-pushed the ci_configuration branch from 4326efb to ed441f6 Compare May 15, 2024 14:47
@beorn- beorn- requested a review from ErwanAliasr1 May 15, 2024 14:48
Copy link
Collaborator

@ErwanAliasr1 ErwanAliasr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thx !

@beorn- beorn- merged commit 1f9c04b into main May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants