Adding Dell Gen14 support #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A TestDell class is created to get a generic setUp(). This class is instanciated by products like c6615. This will ease adding new Dell servers types for mocking. Signed-off-by: Erwan Velu <e.velu@criteo.com>
This commit is about adding Dell C6420 as a new supported model. - Adding oem/power/thermal dumps - Adding a small quirk for the inlet temp that misses a PhysicalContext. Signed-off-by: Erwan Velu <e.velu@criteo.com>
If there is no System.Embedded.1 path, let's use the default Attributes path. This is required to support Gen14 systems. If no OEM entries are found, let's be fatal and report an issue. Signed-off-by: Erwan Velu <e.velu@criteo.com>
The current implementation of get_redfish_url() logs an error every time the get fails. This was added to prevent silent failures. Some endpoints must be present to get a proper monitoring. That said, some calls may depends on the hardware specification meaning that several calls can be needed to get the proper metrics. In that case, the first call will complains while the second will work. This generates very noisy output that makes users feeling something is wrong while everything works as expected. This commit is adding a log_failure paramater to get_redfish_url() to indicate if the call should log a failure or not. This is up to the caller to determine if this flag is necessary. The current implementation keeps the same behavior aka logging every error. This commit silence two calls - one from HPE to detect if we run into a multinode chassis - one from Dell where the OEM metrics can be located in two different paths. Signed-off-by: Erwan Velu <e.velu@criteo.com>
anisse
reviewed
Oct 23, 2024
anisse
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issues reported in #25 , let's add a specific test suite for C6420.