hwgraph: Do not enable same-chassis feature for a single node #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per issue#41, when tracing with a single server, the --same-chassis can be engaged generating a crash like: ~/Devel/hwbench (various)$ python3 -m graph.hwgraph graph --outdir criteo/arno_out --traces ~/Téléchargements/results.json:Arno:BMC.Server environment: All traces are from the same chassis (GYLGS63), enabling --same-chassis feature Traceback (most recent call last): File "<frozen runpy>", line 198, in _run_module_as_main File "<frozen runpy>", line 88, in _run_code File "/home/e.velu/Devel/hwbench/graph/hwgraph.py", line 380, in <module> main() File "/home/e.velu/Devel/hwbench/graph/hwgraph.py", line 376, in main args.func(args) File "/home/e.velu/Devel/hwbench/graph/hwgraph.py", line 61, in render_traces rendered_graphs += graph_environment(args, output_dir) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/e.velu/Devel/hwbench/graph/hwgraph.py", line 234, in graph_environment rendered_graphs += graph_chassis(args, bench_name, output_dir) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/e.velu/Devel/hwbench/graph/chassis.py", line 139, in graph_chassis y_serie = np.array(serie[trace.get_name()])[order] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^ IndexError: index 0 is out of bounds for axis 0 with size 0 This commit is adding a new condition to ensure the same-chassis feature is not engaged for a single system. Signed-off-by: Erwan Velu <e.velu@criteo.com>
|
Worked perfectly fine during my tests! |
Arno500
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue#41, when tracing with a single server, the --same-chassis can be engaged generating a crash like:
This commit is adding a new condition to ensure the same-chassis feature is not engaged for a single system.