environment: some CPU vendors might not expose a model name #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arno500
requested changes
Nov 5, 2024
…the BIOS model name Introduce a fallback so that CPU name detection still works. This is needed because hwbench treats "Model name" as a mandatory key of the `lscpu` output, and on this specific machine it was absent, but "BIOS Model name" was present.
anisse
force-pushed
the
model-name-fallback
branch
from
41e5a57 to
d1a2a5f
Compare
Arno500
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a fallback so that CPU name detection still works.