Add watchers to update budgets in reaction to events #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geobeau
force-pushed
the
consistent-budget
branch
3 times, most recently
from
89356d4 to
b10efd6
Compare
Watch Pods and PVC for ApplicationDisruptionBudgets. Implemented using EnqueueRequestsFromMapFunc. By providing a fan-out function, for each event we can determine which ADB is impacted and notify it. Co-authored-by: Jonathan Amiez <j.amiez@criteo.com>
geobeau
force-pushed
the
consistent-budget
branch
from
b10efd6 to
96e5264
Compare
geobeau
added a commit
to geobeau/node-disruption-controller
that referenced
this pull request
Oct 26, 2023
josqu4red
reviewed
Oct 27, 2023
|
Yes, I will make a refactoring commit to improve the repartition/isolation of each e2e test in a later PR. There are also tests in NodeDisruption that belongs to Application and Node budgets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watch Pods and PVC for ApplicationDisruptionBudgets.
Implemented using EnqueueRequestsFromMapFunc. By providing a fan-out function, for each event we can determine which ADB is impacted and notify it.