Fix nil pointer dereference when trying to find the nodes of a PV that don't have affinity #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubernetes state is not reset by gingko so the state managent needs to be managed manually. It does not support deletion well (things stay terminating forever). So now we follow the recommandation from the doc to spawn a new namespace everytime: https://book.kubebuilder.io/reference/envtest.html#namespace-usage-limitation
Previously, we expected a PV with remote storage to have an empty set of selector but actually all the NodeAffinity section is missing. Now, we check if the pointer is nil Co-authored-by: Thomas Langé <t.lange@criteo.com>
between test, the reconciler is stopped and started again. Stop is not instant but we started a new instance right away. Since it bind a port, the new one crashed because the old one didn't release it yet. Instead we wait for the manager to be properly down before starting a new one
josqu4red
approved these changes
Nov 23, 2023
Lqp1
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we expected a PV with remote storage to have an empty set of selector but actually all the NodeAffinity section is missing. Now, we check if the pointer is nil.
Added 2 others commits: