Fix node-disruption-types containing empty strings #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josqu4red
reviewed
Oct 3, 2024
cmd/main.go
Outdated
| @@ -100,14 +101,16 @@ func main() { | |||
| os.Exit(1) | |||
| } | |||
|
|
|||
| nodeDisruptionTypes := utils.FilterEmptyString(strings.Split(nodeDisruptionTypesRaw, ",")) | |||
There was a problem hiding this comment.
You may want to use strings.FieldsFunc instead of a custom utility func
geobeau
force-pushed
the
fix-empty-types
branch
from
1f723ec to
cf87246
Compare
Split was containing empty string. Now we filter them out to avoid rejecting maintenances.
geobeau
force-pushed
the
fix-empty-types
branch
from
cf87246 to
677fb18
Compare
fquesnel
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split was containing empty string. Now we filter them out to avoid rejecting maintenances.