Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discard not yet reconciliated node disruption #73

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

pgoron
Copy link
Contributor

@pgoron pgoron commented Dec 12, 2024

adb and ndb controllers are reporting information about node disruption not yet reconciliated, for which state is still unknown. It breaks contract of adb/ndb object status where reported nd should have a valid status.

adb and ndb controllers are reporting information about node disruption
not yet reconciliated, for which state is still unknown.
It breaks contract of adb/ndb object status where reported nd should have
a valid status.
Copy link

@fquesnel fquesnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@pgoron pgoron merged commit 37b7627 into criteo:main Dec 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants