Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Add the orderBy parameter to list methods #191

Merged

Conversation

Martin005
Copy link
Contributor

This PR adds the orderBy parameter to the existing list methods.
I got inspired by the implementation in the .NET client library (crowdin/crowdin-api-client-dotnet#251) and I implemented it similarly in Python + I added enums for each list endpoint with possible values to order by.

The following list methods take orderBy parameter, but currently are not in the Python library:

Closes #155

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.36%. Comparing base (86fd49a) to head (4ced9cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   99.22%   99.36%   +0.14%     
==========================================
  Files         166      169       +3     
  Lines        6658     6991     +333     
  Branches      149      158       +9     
==========================================
+ Hits         6606     6946     +340     
+ Misses         36       30       -6     
+ Partials       16       15       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Martin005 thanks a lot for such a great contribution, I like the way how it's implemented! 🚀

@andrii-bodnar andrii-bodnar merged commit cbaa577 into crowdin:main Dec 6, 2024
6 checks passed
@Martin005 Martin005 deleted the orderby-parameter-list-methods branch December 6, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the orderBy parameter to list methods
3 participants