Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Umami #114

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add Umami #114

wants to merge 1 commit into from

Conversation

SailReal
Copy link
Member

@SailReal SailReal commented Jan 9, 2025

No description provided.

@SailReal SailReal requested a review from tobihagemann January 9, 2025 18:37

This comment was marked as off-topic.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
hugo.toml (1)

119-119: Consider removing Plausible analytics when adding Umami

The CSP header now allows both Plausible and Umami analytics to run simultaneously. This raises several concerns:

  1. Dual tracking may impact user privacy and GDPR compliance
  2. Running two analytics services affects page load performance
  3. Increased network requests and JavaScript execution overhead

Consider migrating completely from Plausible to Umami instead of running both services in parallel. If this is a transitional phase, please document the migration timeline.

- Content-Security-Policy = "default-src 'none'; script-src 'self' 'unsafe-eval' https://umami.skymatic.de/ https://plausible.skymatic.de/ https://community.cryptomator.org/ https://js.stripe.com/ https://*.paddle.com/ https://www.google.com/ https://www.gstatic.com/; style-src 'self' 'unsafe-inline' https://*.paddle.com/; img-src 'self' data: https://static.cryptomator.org/ https://*.paddle.com/ https://paddle.s3.amazonaws.com/; connect-src 'self' https://api.cryptomator.org/ https://store.cryptomator.org/ https://umami.skymatic.de/ https://plausible.skymatic.de/ http://localhost:8787/; font-src 'self'; media-src https://static.cryptomator.org/; frame-src https://community.cryptomator.org/ https://js.stripe.com/ https://*.paddle.com/ https://www.google.com/; base-uri 'self'; form-action 'self' https://www.paypal.com/ https://www.coinpayments.net/; frame-ancestors 'none'"
+ Content-Security-Policy = "default-src 'none'; script-src 'self' 'unsafe-eval' https://umami.skymatic.de/ https://community.cryptomator.org/ https://js.stripe.com/ https://*.paddle.com/ https://www.google.com/ https://www.gstatic.com/; style-src 'self' 'unsafe-inline' https://*.paddle.com/; img-src 'self' data: https://static.cryptomator.org/ https://*.paddle.com/ https://paddle.s3.amazonaws.com/; connect-src 'self' https://api.cryptomator.org/ https://store.cryptomator.org/ https://umami.skymatic.de/ http://localhost:8787/; font-src 'self'; media-src https://static.cryptomator.org/; frame-src https://community.cryptomator.org/ https://js.stripe.com/ https://*.paddle.com/ https://www.google.com/; base-uri 'self'; form-action 'self' https://www.paypal.com/ https://www.coinpayments.net/; frame-ancestors 'none'"
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 392b557 and a9f7cdd.

📒 Files selected for processing (2)
  • hugo.toml (1 hunks)
  • layouts/_default/baseof.html (1 hunks)
🔇 Additional comments (1)
layouts/_default/baseof.html (1)

81-81: Verify Umami script features parity with Plausible

The Plausible script includes additional features in its URL:

  • file-downloads
  • hash
  • outbound-links
  • tagged-events

Please ensure that Umami provides equivalent tracking capabilities for:

  1. File download tracking
  2. URL hash tracking
  3. Outbound link tracking
  4. Custom event tracking

If any features are missing, document the gaps and their impact on analytics data collection.

Also applies to: 86-86

@@ -78,10 +78,12 @@
{{ partial "footer.html" . }}
{{ if hugo.IsServer }}
<script data-domain="cryptomator.local" src="https://plausible.skymatic.de/js/script.file-downloads.hash.outbound-links.tagged-events.local.js" integrity="sha384-eSdyNyMq4w2Hzeb7A3pkbi2+zvI/skXuKlWsX5uzccigZEHDhHyBYoTASuSW+ZUQ" crossorigin="anonymous" defer></script>
<script src="https://umami.skymatic.de/script.js" data-website-id="57a36f3a-bd97-4d8a-9563-0e8d39ddb20c" integrity="sha384-/WQteTtaLX4nU22mvCeTi4Yz3iK/J3yZ2rKq5jDxPMlizEQGzgJOlSofJxh+bx4B" crossorigin="anonymous" defer></script>

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant