Make product name mutable again #1007
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodewiges
requested changes
Jan 19, 2025
lodewiges
reviewed
Jan 23, 2025
| subject(:product) { create(:product) } | ||
|
|
||
| it { expect(product.update(name: 'new_name')).to be false } | ||
| end |
There was a problem hiding this comment.
instead of removing the test we could edit it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #937
Basically reverts #598
The concern with #595 was that users were modifying product names when they really just wanted to create a new product. Should we provide the user with a warning, like a tooltip or a dialog?