Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Codebase to Enhance Contribution Readiness #59

Merged
merged 24 commits into from
Dec 16, 2024

Conversation

Ma11hewThomas
Copy link
Contributor

@Ma11hewThomas Ma11hewThomas commented Dec 7, 2024

This PR refactors the codebase, resolving lint issues and incorporating feedback to improve maintainability. Once merged, the project will be in a strong position to welcome new contributions.

Key Changes

Adopted Octokit for API client: Streamlines interactions with GitHub's API.
Migrated all templates to Handlebars: Special thanks to @timkrins for the suggestion!
Rewrote processing reliability metrics: Enhances accuracy and reliability.
Introduced a new Community Templates section: Encourages the creation of custom reports.

Preview the Changes

The changes are available in the beta release v0.0.50-rc.5 for testing over the next week. You can try it out using the following command:

npx github-actions-ctrf@0.0.50-rc.5 ctrf-reports/ctrf-report.json

Feedback is welcome before the final merge!

Copy link

github-actions bot commented Dec 7, 2024

testing: Run #9

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
14 14 0 0 0 0 14 4.5s

🎉 All tests passed!

Github Test Reporter

@Ma11hewThomas Ma11hewThomas self-assigned this Dec 7, 2024
Copy link

github-actions bot commented Dec 7, 2024

testing: Run #11

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
14 14 0 0 0 0 0 4.7s

🎉 All tests passed!

Github Test Reporter

Copy link

github-actions bot commented Dec 8, 2024

testing: Run #18

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
14 14 0 0 0 0 0 4.8s

🎉 All tests passed!

Github Test Reporter

@Ma11hewThomas Ma11hewThomas changed the title Feat/refactor Refactored Codebase to Enhance Contribution Readiness Dec 8, 2024
@Ma11hewThomas
Copy link
Contributor Author

@joaquinjsb this release candidate includes a migration to octokit for the client, which might resolve the issue #58.

Copy link

github-actions bot commented Dec 9, 2024

testing: Run #20

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
14 14 0 0 0 0 0 4.9s

🎉 All tests passed!

Github Test Reporter

Copy link

github-actions bot commented Dec 9, 2024

testing: Run #22

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
14 14 0 0 0 0 0 4.9s

🎉 All tests passed!

Github Test Reporter

Copy link

github-actions bot commented Dec 9, 2024

testing: Run #24

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
14 14 0 0 0 0 0 4.8s

🎉 All tests passed!

Github Test Reporter

@joaquinjsb
Copy link

@joaquinjsb this release candidate includes a migration to octokit for the client, which might resolve the issue #58.

thanks, I may test it soon

Copy link

testing: Run #26

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
14 14 0 0 0 0 0 4.8s

🎉 All tests passed!

Github Test Reporter

Copy link

testing: Run #28

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
14 14 0 0 0 0 0 4.7s

🎉 All tests passed!

Github Test Reporter

@timkrins
Copy link

I ❤️ the handlebars templates :)

Copy link

testing: Run #30

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
14 14 0 0 0 0 0 4.6s

🎉 All tests passed!

Github Test Reporter

Copy link

testing: Run #32

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
14 14 0 0 0 0 0 4.6s

🎉 All tests passed!

Github Test Reporter

Copy link

testing: Run #34

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
14 14 0 0 0 0 0 4.6s

🎉 All tests passed!

Github Test Reporter

Copy link

testing: Run #36

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
14 14 0 0 0 0 0 4.9s

🎉 All tests passed!

Github Test Reporter

@Ma11hewThomas Ma11hewThomas merged commit 0cc19f6 into main Dec 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants