Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set start & stop times so durtion can be properly calculated #6

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

asherf
Copy link
Collaborator

@asherf asherf commented Sep 8, 2024

noticed (using https://github.com/ctrf-io/github-actions-test-reporter-ctrf) that the duration is always zero.. dug into it and noticed the relevant properties in the summary are not set.
so I think this will fix it.

fixes: #2

@Ma11hewThomas
Copy link
Contributor

Ma11hewThomas commented Sep 9, 2024

Thank you for your contributions, they are really appreciated

@coveralls
Copy link

coveralls commented Sep 9, 2024

Pull Request Test Coverage Report for Build 10818040013

Details

  • 0 of 48 (0.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-3.3%) to 39.6%

Changes Missing Coverage Covered Lines Changed/Added Lines %
reporter/reporter.go 0 48 0.0%
Files with Coverage Reduction New Missed Lines %
reporter/reporter.go 3 0.0%
Totals Coverage Status
Change from base Build 10817889475: -3.3%
Covered Lines: 99
Relevant Lines: 250

💛 - Coveralls

@Ma11hewThomas Ma11hewThomas merged commit 353349e into ctrf-io:main Sep 11, 2024
6 checks passed
@asherf asherf deleted the fix-duration branch September 11, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add start and stop to test object
3 participants