Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove request promise in favor of node-fetch #9069

Merged
merged 10 commits into from
Jan 9, 2025

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jan 6, 2025

This is a followup PR with resolved conflicts of the original #8233 by @jlloyd-widen

  • switched from request-promise to node-fetch
  • linting fix
  • removed unnecessary babel changes
  • more unnecessary babel changes
  • attempting fix to schema compiler integration tests
  • reverting schema compiler changes
  • Update packages/cubejs-cli/src/command/typegen.ts
  • udpate internal yarn.lock deps

@KSDaemon KSDaemon changed the title chore/remove request promise chore: Remove request promise in favor of node-fetch Jan 6, 2025
@KSDaemon KSDaemon force-pushed the chore/remove-request-promise branch from 6c39b86 to 890c297 Compare January 8, 2025 16:16
@KSDaemon KSDaemon marked this pull request as ready for review January 8, 2025 17:43
@KSDaemon KSDaemon requested review from a team as code owners January 8, 2025 17:43
@KSDaemon KSDaemon merged commit cd91f7d into master Jan 9, 2025
51 checks passed
@KSDaemon KSDaemon deleted the chore/remove-request-promise branch January 9, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants