Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild go packages if go.mod changes #1609

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Rebuild go packages if go.mod changes #1609

merged 1 commit into from
Jun 11, 2021

Conversation

mattwynne
Copy link
Member

@mattwynne mattwynne commented Jun 11, 2021

Summary

Change default Makefile for Go packages to rebuild if the go.mod file changes

Motivation and Context

I'm working on #1550 and fiddling about with the go.mod files. It seems the Makefile needs this dependency expressed.

Types of changes

  • Technical debt
  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Copy link
Member

@mxygem mxygem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not super familiar with Make’s behaviors but it seems logical that if dependencies change that things should be rebuilt.

Copy link
Contributor

@aslakhellesoy aslakhellesoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattwynne mattwynne changed the title Also rebuild go packages if go.mod changes Rebuild go packages if go.mod changes Jun 11, 2021
@mattwynne mattwynne merged commit eb206b2 into main Jun 11, 2021
@mattwynne mattwynne deleted the update-go-make branch June 11, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants