Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo for alternation in optional error message #253

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Fix typo for alternation in optional error message #253

merged 2 commits into from
Dec 3, 2023

Conversation

kieran-ryan
Copy link
Member

@kieran-ryan kieran-ryan commented Dec 3, 2023 •
edited
Loading

Fixes repeated 'the' in the error message for an alternation inside an optional.

🤔 What's changed?

  • Removed all 'the' repeats in error messages for alternations inside optionals.
  • Fixed typo in Architecture.md - is not a valid a Cucumber Expression -> is not a valid Cucumber Expression
  • Fixed alignment and formatting of Python parameter example in README.md

⚡️ What's your motivation?

Fixes #252

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

NA.

📋 Checklist:

@kieran-ryan kieran-ryan self-assigned this Dec 3, 2023
@kieran-ryan kieran-ryan marked this pull request as ready for review December 3, 2023 14:29
@kieran-ryan kieran-ryan changed the title Fix typo for alternation in optional error Fix typo for alternation in optional error message Dec 3, 2023
mpkorstanje
mpkorstanje approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! LGTM.

Please do add a new ### Fixed section to CHANGELOG.md with an entry detailing this fix.

@kieran-ryan kieran-ryan force-pushed the typo-alternation-in-optional branch from ea89175 to b61d460 Compare December 3, 2023 17:13
@kieran-ryan kieran-ryan merged commit 15720cb into cucumber:main Dec 3, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpkorstanje mpkorstanje mpkorstanje approved these changes

Assignees

@kieran-ryan kieran-ryan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in error message for use of alternation inside an optional
2 participants
@kieran-ryan @mpkorstanje