Skip to content

Commit

Permalink
Improve CCK comments about ignorability of tests
Browse files Browse the repository at this point in the history
  • Loading branch information
luke-hill committed Jan 6, 2025
1 parent 1649a8a commit 9e0393b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions compatibility/support/cck/messages_comparator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def not_message?(detected)
!detected.is_a?(Cucumber::Messages::Message)
end

# These messages we need to ignore because they are too large or they feature timestamps which always vary
# These messages need to be ignored because they are too large, or they feature timestamps which will be different
def ignorable?(detected)
too_large_message?(detected) || time_message?(detected)
end
Expand All @@ -73,7 +73,7 @@ def time_message?(detected)
detected.is_a?(Cucumber::Messages::Timestamp) || detected.is_a?(Cucumber::Messages::Duration)
end

# These messages we need to ignore because they are often not of identical shape/value
# These messages need to be ignored because they are often not of identical shape
def incomparable?(detected)
detected.is_a?(Cucumber::Messages::Ci) || detected.is_a?(Cucumber::Messages::Git)
end
Expand Down

0 comments on commit 9e0393b

Please sign in to comment.