Not for merge: 9.2 backports #1775
Conversation
* Pass hash through as explicit hash to avoid unknown keyword argument error. * Changelog entry for #1757
Created-by: polyglot-release v1.6.0
| @@ -75,7 +75,9 @@ def row(row) | |||
| def eof; end | |||
| end | |||
|
|
|||
| NULL_CONVERSIONS = Hash.new(strict: false, proc: ->(cell_value) { cell_value }).freeze | |||
| # This is a Hash being initialized with a default value of a Hash, DO NOT REFORMAT TO REMOVE {} | |||
| # Future versions [3.4.0+] of ruby will interpret these as keywords and break. | |||
There was a problem hiding this comment.
is it possible to change from "future" to just "3.4"? Future is not accurate anymore
| # Future versions [3.4.0+] of ruby will interpret these as keywords and break. | |
| # Ruby versions from 3.4.0 onwards interpret these as keywords and break. |
There was a problem hiding this comment.
I'll fix this up in main when we cut a v10. For now I'm focussing on getting the stuff out which is causing some issues.
|
@luke-hill is there anything I (or anybody) can do to help you get this landed? |
|
There's an issue currently with the api token. I'm not quite sure what though. I've spoken to the team internally and we need to investigate why this happened. If it will take a while I'm tempted to just regenerate the overall key and re-add it to each repo. But I don't actually know why it stopped working. See here |
|
Mmmm, yeah probably not something that anybody else can help with directly. Maybe the token expired? |
|
if a new API key is needed, is it possible to reconsider this? RubyGems should support skipping MFA for API keys, so it should be possible to opt-in for MFA |
|
I just went nuclear and purged everything and re-generated everything. Then pushing to 9.2.1 worked. In doing so I realised the way we were doing our API keys was a bit clunky, so I tidied it up for everything else. Will close this ticket off as completed. The next release will be a v10 one as I don't want to faff around with any more backports. If I can carry on with the v10 stuff it should be done soon |
TBC:
9.3mainDescription
Type of change
Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses