Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct favicon #341

Merged
merged 5 commits into from
Dec 23, 2024
Merged

Use correct favicon #341

merged 5 commits into from
Dec 23, 2024

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Dec 20, 2024

🤔 What's changed?

Change the embedded SVG favicon for the HTML file to be the correct (non-SmartBear) Cucumber mark.

Also, tweak the acceptance test in the javascript package so each example is output to a file for easy inspection.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss changed the title Update icon Use correct favicon Dec 22, 2024
@davidjgoss davidjgoss marked this pull request as ready for review December 22, 2024 09:03
@luke-hill
Copy link
Contributor

For simplicity can we see a before / after. But the code seems fine from my end

@mattwynne mattwynne merged commit be5390d into main Dec 23, 2024
14 checks passed
@mattwynne mattwynne deleted the update-icon branch December 23, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants