Add explicit CCK download to make PHP acceptance tests run

docker-bake.hcl

@@ -112,6 +112,8 @@ target "php-test" {
   context = "php"
   target = "tested"
   contexts = {
+    # replaces the stage that does `git clone` and ensures we get a fresh version
+    cck = "https://github.com/cucumber/compatibility-kit.git#main:devkit",
     schema-codegen = "target:php-codegen",
   }
 }

php/Dockerfile

@@ -9,6 +9,15 @@ WORKDIR /cucumber
 FROM scratch AS schema-codegen
 
 
+# Stage to download the CCK data, overridden in main build but included here in case building in the subfolder
+# NB - when buildkit 1.5 is released this can be replaced with an ADD from the git URL
+FROM bitnami/git AS cck
+RUN git clone https://github.com/cucumber/compatibility-kit.git \
+    && cd compatibility-kit \
+    && git checkout main \
+    && cp -R ./devkit/samples /samples
+
+
 FROM php AS with-dependencies
 
 COPY --link composer.json .
@@ -23,6 +32,7 @@ FROM php AS tested
 COPY --link . .
 COPY --link --from=with-dependencies /cucumber/vendor vendor
 COPY --link --from=schema-codegen / src-generated
+COPY --link --from=cck /samples/ ./tests/cck-samples
 RUN vendor/bin/php-cs-fixer --dry-run --diff fix
 RUN vendor/bin/psalm --no-cache
 RUN vendor/bin/phpunit

php/composer.json

@@ -28,7 +28,8 @@
             "Cucumber\\Messages\\": [
                 "src",
                 "src-generated",
-                "tests"
+                "tests",
+                "tests/unit"
             ]
         }
     }

php/phpunit.xml

@@ -12,8 +12,11 @@
          failOnWarning="true"
          verbose="true">
     <testsuites>
-        <testsuite name="default">
-            <directory>tests</directory>
+        <testsuite name="unit">
+            <directory>tests/unit</directory>
+        </testsuite>
+        <testsuite name="end-to-end">
+            <file>tests/CckTest.php</file>
         </testsuite>
     </testsuites>
 

php/tests/AcceptanceTest.php → php/tests/CckTest.php

@@ -1,11 +1,14 @@
 <?php
 
-use Cucumber\Messages\Envelope;
+namespace Cucumber\Messages;
+
 use Cucumber\Messages\Streams\NdJson\NdJsonStreamReader;
 use Cucumber\Messages\Streams\NdJson\NdJsonStreamWriter;
+use Exception;
+use Generator;
 use PHPUnit\Framework\TestCase;
 
-class AcceptanceTest extends TestCase
+class CckTest extends TestCase
 {
     /** @dataProvider provideJsonLines */
     public function testAllNdJsonSurvivesDecodingThenEncoding(string $json): void
@@ -74,6 +77,13 @@ public function provideNdJsonFilenames(): Generator
      */
     private function getSampleFiles(): array
     {
-        return glob(__DIR__ . '/../../../node_modules/@cucumber/compatibility-kit/features/**/*.ndjson') ?: [];
+        $files = glob(pattern:__DIR__ . '/cck-samples/**/*.ndjson');
+
+        // glob doesn't error if dir is empty
+        if ($files === []) {
+            throw new Exception('CCK sample files not found. Perhaps you want to run the "unit" testsuite?');
+        }
+
+        return $files;
     }
 }

php/tests/cck-samples/.gitignore

@@ -0,0 +1 @@
+*

php/tests/EnvelopeTest.php → php/tests/unit/EnvelopeTest.php

@@ -1,9 +1,7 @@
 <?php
 
-use Cucumber\Messages\Envelope;
-use Cucumber\Messages\Feature;
-use Cucumber\Messages\GherkinDocument;
-use Cucumber\Messages\Location;
+namespace Cucumber\Messages;
+
 use PHPUnit\Framework\TestCase;
 
 class EnvelopeTest extends TestCase

php/tests/JsonDecodingTraitTest.php → php/tests/unit/JsonDecodingTraitTest.php

@@ -1,10 +1,13 @@
 <?php
 
+namespace Cucumber\Messages;
+
 use Cucumber\Messages\DecodingException\MalformedJsonException;
-use Cucumber\Messages\JsonEncodingTrait;
 use Cucumber\Messages\DecodingException\SchemaViolationException;
 use Cucumber\Messages\DecodingException\UnexpectedDecodingException;
+use JsonSerializable;
 use PHPUnit\Framework\TestCase;
+use RuntimeException;
 
 class JsonDecodingTraitTest extends TestCase
 {