Solving some issues in https://github.com/culqi/culqi-prestashop/issues/19 #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Related to: #19
General fixes:
"
quotes force PHP to parse the string as PHP code and this takes longer. Using'
when dealing with a pure string improves speed.dirname(__FILE__)
with simply__DIR__
as this has the same result.request
functions throw errors, but none are caught. They are now documented.I would recommend you open up a new issue for this code to include code styling and if possible switch to composer to maintain your dependencies on things like fsockopen.