Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving some issues in https://github.com/culqi/culqi-prestashop/issues/19 #20

Closed
wants to merge 2 commits into from
Closed

Conversation

hyperized
Copy link

Hi there,

Related to: #19

General fixes:

  • Removed redundant use of quotes. " quotes force PHP to parse the string as PHP code and this takes longer. Using ' when dealing with a pure string improves speed.
  • Replaced dirname(__FILE__) with simply __DIR__ as this has the same result.
  • Notice how most request functions throw errors, but none are caught. They are now documented.
  • Optimizing PHP function calls.
  • Replacing for with foreach.
  • Minor JS + CSS fixes.

I would recommend you open up a new issue for this code to include code styling and if possible switch to composer to maintain your dependencies on things like fsockopen.

@hyperized hyperized closed this Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant