block node and createEditor
#173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated demo to have legacy editor creation and next - parameterize store for comments plugins in footnote
Yxwww
commented
Sep 21, 2022
| @@ -118,7 +125,23 @@ function CodeActions(props: ActionProps) { | |||
|
|
|||
| if (!editorState || !node || pos == null) return null; | |||
|
|
|||
| const onDelete = () => dispatch(deleteNode(stateId, viewId, { node, pos })); | |||
| const onDelete = () => { | |||
| const foundParentFigureResult = findParentNodeOfTypeClosestToPos( | |||
There was a problem hiding this comment.
Fixes an issue where delete code actions does not delete the figure wrapped around it
| @@ -19,6 +20,23 @@ export const initialState: EditorsState = { | |||
| // eslint-disable-next-line @typescript-eslint/default-param-last | |||
| const editorReducer = (state = initialState, action: EditorActionTypes): EditorsState => { | |||
| switch (action.type) { | |||
| case REGISTER_EDITOR_STATE: { | |||
There was a problem hiding this comment.
Make it so that we can directly register editor state using the state object. The future goal is not having editor state in redux at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
articleschema preset that uses a block node as the top level node