Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource values for nginx and postgres #186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davejab
Copy link

@davejab davejab commented Sep 6, 2023

Desired Outcome

Expose chart values to set resource requests and limits on nginx + postgres pods.

Implemented Changes

Resource value configuration has been exposed allowing users to customise requests + limits for nginx + postgres pods. This was a requirement for our cluster as we have strict policies in place that require all pods to have resources defined.

Connected Issue/Story

n/a

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@davejab davejab requested a review from a team as a code owner September 6, 2023 09:34
@szh szh self-assigned this Sep 6, 2023
@szh
Copy link
Contributor

szh commented Sep 15, 2023

Hi @davejab,

Thank you for submitting this PR. It looks great but we need to have a test case before we can merge it. We're currently evaluating how to refactor our tests in this repository so we can easily add test cases. In the meantime I'll leave this PR open and we'll get back to it once we rework the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants